D5163: filelog: add a hasnode() method (API)
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed Oct 31 16:11:34 EDT 2018
indygreg added inline comments.
INLINE COMMENTS
> martinvonz wrote in filelog.py:41
> node can be nullrev?
That was me possibly being a bit overzealous.
We should consider removing it.
I may have added it because `revlog.rev()` seems to always support `nullid` and `nullrev`, so you need to check for both explicitly at higher levels.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5163
To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list