D4372: index: embed nodetree in index object to avoid reference cycle

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.


  I haven't had time to dig into this, but I bisected a hard crash back to here on Windows.
  
    --- c:/Users/Matt/projects/hg/tests/test-revisions.t
    +++ c:/Users/Matt/projects/hg/tests/test-revisions.t.err
    @@ -40,6 +40,6 @@
       [255]
     7b is no longer ambiguous
       $ hg l -r 7b
    -  3:7b
    +  [5]
    
       $ cd ..
  
  @ has an earlier failure too, so possibly it's random-ish.
  
    --- c:/Users/Matt/projects/hg/tests/test-revisions.t
    +++ c:/Users/Matt/projects/hg/tests/test-revisions.t.err
    @@ -31,6 +31,7 @@
       2:72
       1:9
       0:b
    +  [5]
     9 was unambiguous and still is
       $ hg l -r 9
       1:9
    @@ -40,6 +41,6 @@
       [255]
     7b is no longer ambiguous
       $ hg l -r 7b
    -  3:7b
    +  [5]
    
       $ cd ..

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4372

To: martinvonz, #hg-reviewers
Cc: mharbison72, yuja, mercurial-devel