D4435: wireprotov2peer: add TODO about streaming responses

[indygreg (Gregory Szorc)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1467b6c27ff9: wireprotov2peer: add TODO about streaming responses (authored by indygreg, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D4435?vs=10692&id=10756

REVISION DETAIL
  https://phab.mercurial-scm.org/D4435

AFFECTED FILES
  mercurial/wireprotov2peer.py

CHANGE DETAILS

diff --git a/mercurial/wireprotov2peer.py b/mercurial/wireprotov2peer.py
--- a/mercurial/wireprotov2peer.py
+++ b/mercurial/wireprotov2peer.py
@@ -136,6 +136,9 @@
         response = self._responses[frame.requestid]
 
         if action == 'responsedata':
+            # This buffers all data until end of stream is received. This
+            # is bad for performance.
+            # TODO make response data streamable
             response.b.write(meta['data'])
 
             if meta['eos']:



To: indygreg, #hg-reviewers, pulkit
Cc: mjpieters, mercurial-devel