D4483: wireprotov2: add phases to "changesetdata" command

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Sep 5 17:41:20 EDT 2018


pulkit added inline comments.

INLINE COMMENTS

> wireprotocolv2.txt:155
> +phase (optional)
> +   (bytestring) The phase that a revision is in. Recognized values are
> +   ``secret``, ``draft``, and ``public``. Only present if ``phase`` data

Won't it be better to use phase numbers here because that's how we represent phases at most of the places. If you agree, I can send a followup for that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4483

To: indygreg, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list