D4483: wireprotov2: add phases to "changesetdata" command

[indygreg (Gregory Szorc)]

indygreg added inline comments.

INLINE COMMENTS

> pulkit wrote in wireprotocolv2.txt:155
> Won't it be better to use phase numbers here because that's how we represent phases at most of the places. If you agree, I can send a followup for that.

I have no strong opinions. Using strings is more flexible in that it allows the local integer mappings to be independent of what the server exposes and therefore allows tweaking local-only behavior without incurring server BC. But that's a rather weak argument since I don't expect the definition of phases to change in the near future. And it it did change, we'd likely expose it as a different `field` in the server API to reflect the change in semantic behavior.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4483

To: indygreg, #hg-reviewers
Cc: pulkit, mercurial-devel