D4508: lazyancestors: reuse __iter__ implementation in __contains__

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Sep 8 04:33:19 EDT 2018


yuja added a comment.


  > +        self._containsseen = set()
  >  +        self._containsiter = iter(self)
  
  Perhaps __iter__() needs to be extracted to a free function to avoid
  reference cycle.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4508

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list