[PATCH] phase: report number of non-public changeset alongside the new range

Yuya Nishihara yuya at tcha.org
Sat Sep 8 04:31:17 EDT 2018


On Fri, 07 Sep 2018 11:07:52 -0400, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld at octobus.net>
> # Date 1535586801 -7200
> #      Thu Aug 30 01:53:21 2018 +0200
> # Node ID 5f931c1d1422e9a8c08cca3a59804b25a1183449
> # Parent  ab452995eafffa69c34e863e4d8c03e163d8f3ad
> # EXP-Topic phase-report
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 5f931c1d1422
> phase: report number of non-public changeset alongside the new range

Queued, thanks.

> -            repo.ui.status(_('new changesets %s\n') % revrange)
> +            draft = len(repo.revs('%ld and draft()', revs))
> +            secret = len(repo.revs('%ld and secret()', revs))
> +            if not (draft or secret):
> +                msg = _('new changesets %s\n') % revrange
> +            elif draft and secret:
> +                msg = _('new changesets %s (%d drafts, %d secrets)\n')
> +                msg %= (revrange, draft, secret)
> +            elif draft:
> +                msg = _('new changesets %s (%d drafts)\n')
> +                msg %= (revrange, draft)
> +            elif secret:
> +                msg = _('new changesets %s (%d secrets)\n')
> +                msg %= (revrange, secret)

Added "else: raise ProgrammingError" to make sure msg is otherwise defined.

> +            repo.ui.status(msg)

Can you add tests for 'draft and secret' and 'not draft and secret' cases?


More information about the Mercurial-devel mailing list