D4341: sparse: add local files to temporaryfiles if they exist out of sparse

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Sep 10 11:41:42 EDT 2018


martinvonz requested changes to this revision.
martinvonz added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sparse.py:365
> +        if branchmerge:
> +            if args and len(args) == 5:
> +                f1, f2, fa, move, anc = args

This seems both cryptic and brittle. Can we instead do something like this?

  if type in (merge.ACTION_MOVE, merge.ACTION_...):
    f1, f2, fa, move, anc = args

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4341

To: pulkit, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list