D4521: narrow: add narrow and ellipses as server capabilities

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Sep 10 13:47:57 EDT 2018


martinvonz added a comment.


  > checking bundle2 capability which does not scale outside of bundle2 world.
  
  Is your goal to use narrowness without ellipsis nodes with a changegroup1 server? Can we split this patch up so it just splits up the "narrow" capability into "narrow" and "ellipsis" and then we can consider cg1 support in a separate patch?

INLINE COMMENTS

> narrowbundle2.py:35
>  NARROWCAP = 'narrow'
> +NELLIPSESCAP = 'narrow-ellipses'
>  _NARROWACL_SECTION = 'narrowhgacl'

I'd rather not include "narrow" in the name. It doesn't necessarily require narrowness. You can imagine using ellipsis nodes to achieve a shallow clone that still has all paths.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4521

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list