D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In https://phab.mercurial-scm.org/D4522#69130, @indygreg wrote:
  
  > Looking through this code a bit more, it appears that there is a not-in-core "remote expansion" wire protocol command that recognizes the `include:` prefix and asks the server to expand it. This series will stop that from working.
  >
  > I didn't notice this at first because we have no tests for it.
  >
  > I //think// Google's server relies on this feature.
  >
  > @martinvonz how do you want to proceed? Should we nuke the `include:` feature in core? Or do you want me to refactor this series to support the `include:` on user-provided commands?
  
  
  Heh, we were talking about that internally and were surprised that this patch didn't mention that and that no tests failed. We realized a month or so ago that while the server has support for it, there was some renaming of a capability that happened when narrow was moved into the hg repo that meant that no one could possibly have used the feature since then. Kyle and I are okay with forbidding `include:`. We can also add it back, or override it internally, if we decide that we want to let users use that feature again. Thanks for asking :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4522

To: indygreg, durin42, #hg-reviewers
Cc: martinvonz, mjpieters, mercurial-devel