D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Sep 11 18:11:50 EDT 2018
indygreg added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowspec.py:114-130
> Obsolete copy of what you inlined into parsepatterns?
It is a copy, but not obsolete.
`parsepatterns()` normalizes patterns supplied by the user or an untrusted source. `validatepatterns` is used on "internal" data structures to ensure things are well-formed.
They do similar things but are different. I could extract the common bit to a separate, two-line function and/or update the docstring to reflect the differences. Do you have any preferences?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4522
To: indygreg, durin42, #hg-reviewers, martinvonz
Cc: martinvonz, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list