D4526: narrow: validate spec files are well-formed during clone (BC)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Sep 11 18:23:35 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> test-narrow-clone-no-ellipsis.t:133
>    > path:dir/tests/
> -  > file:dir/src/f12
>    > EOF

Maybe "file:" was just a typo for "path:" so it's better to replace it by "path:" (instead of having both)?

> test-narrow-clone.t:279
>    reading narrowspec from '$TESTTMP/narrowspecs'
> -  requesting all changes
>    abort: narrow pattern must begin with the following prefixes: path:, rootfilesin:; got glob:**

Any idea why this changed? Should it actually change in this patch?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4526

To: indygreg, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list