D4535: hg: allow extra arguments to be passed to repo creation

Yuya Nishihara yuya at tcha.org
Wed Sep 12 08:25:26 EDT 2018


> +def filterknowncreateopts(ui, createopts):
> +    """Filters a dict of repo creation options against options that are known.

Nit: I thought this would select only known options.

> +        raise error.Abort(_('unable to create repository because of unknown '
> +                            'creation option: %s') %
> +                          ', '.sorted(unknownopts.keys()),

Removed `.keys()` to make it clearer that we don't need a new list on Py2.


More information about the Mercurial-devel mailing list