D4535: hg: allow extra arguments to be passed to repo creation

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Sep 12 08:43:54 EDT 2018


yuja added a comment.


  > +def filterknowncreateopts(ui, createopts):
  >  +    """Filters a dict of repo creation options against options that are known.
  
  Nit: I thought this would select only known options.
  
  > +        raise error.Abort(_('unable to create repository because of unknown '
  >  +                            'creation option: %s') %
  >  +                          ', '.sorted(unknownopts.keys()),
  
  Removed `.keys()` to make it clearer that we don't need a new list on Py2.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4535

To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list