D4475: setup: don't support py 3.5.0, 3.5.1, 3.5.2 because of bug in codecs

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Sep 12 10:52:40 EDT 2018


durin42 added a comment.


  In https://phab.mercurial-scm.org/D4475#68453, @indygreg wrote:
  
  > I'm a bit wary of version sniffing for the same reason that `User-Agent` sniffing is bad in web design: it assumes that version number strings map to behavior. The best way to test for compatibility is to actually test for the feature/behavior and then act appropriately. For example, `setup.py` would try running `codecs.escape_encode(b'')` and then bail if the buggy behavior is encountered.
  
  
  The version-sniffing here is actually done by pip when considering what wheels etc to download, so it will actually help the user out considerably as I understand it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4475

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, durin42, mercurial-devel


More information about the Mercurial-devel mailing list