D4490: wireprotov2: define and implement "filedata" command

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Sep 12 11:11:59 EDT 2018


durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.


  In general I'm happy with where this is going, but I'm extremely uncomfortable with the manifest and filelog commands requiring so much client-server transfer to get everything, especially the rpc-per-file nature of this. It's elegant in terms of how easy it'll make remotefilelog et al, but it makes me worried about performance in the small-repo case where today we can just issue one big hoss RPC for everything and we get it all in one go.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4490

To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list