D4588: py3: fix kwargs handling in hgext/fastannotate.py
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Sun Sep 16 11:49:44 EDT 2018
pulkit added inline comments.
INLINE COMMENTS
> indygreg wrote in commands.py:212-217
> Shouldn't we be doing the ``pycompat.byteskwargs()` at the beginning of the function and using regular string literals on the keys we set?
We can do that, but then in the end we have to do `pycompat.strkwargs()` again to pass into orig() into line 220 below. So I am preventing a conversion here is rev is None.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4588
To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list