D4626: transaction: make releasefn a private attribute
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Mon Sep 17 23:36:24 UTC 2018
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a handle on a callable that is called when the journal
is closed. The value is specified at __init__ time. It doesn't
need to be exposed on the public interface. So mark it as private.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4626
AFFECTED FILES
mercurial/transaction.py
CHANGE DETAILS
diff --git a/mercurial/transaction.py b/mercurial/transaction.py
--- a/mercurial/transaction.py
+++ b/mercurial/transaction.py
@@ -143,7 +143,7 @@
# A callback to do something just after releasing transaction.
if releasefn is None:
releasefn = lambda tr, success: None
- self.releasefn = releasefn
+ self._releasefn = releasefn
self.checkambigfiles = set()
if checkambigfiles:
@@ -513,8 +513,8 @@
self._backupentries = []
self._journal = None
- self.releasefn(self, True) # notify success of closing transaction
- self.releasefn = None # Help prevent cycles.
+ self._releasefn(self, True) # notify success of closing transaction
+ self._releasefn = None # Help prevent cycles.
# run post close action
categories = sorted(self._postclosecallback)
@@ -586,8 +586,8 @@
self.report(_("rollback failed - please run hg recover\n"))
finally:
self._journal = None
- self.releasefn(self, False) # notify failure of transaction
- self.releasefn = None # Help prevent cycles.
+ self._releasefn(self, False) # notify failure of transaction
+ self._releasefn = None # Help prevent cycles.
def rollback(opener, vfsmap, file, report, checkambigfiles=None):
"""Rolls back the transaction contained in the given file
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list