D4636: changegroup: improve the devel-warn to specify changelog was empty

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Sep 18 06:43:43 EDT 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Right now, the develwarn says "applied empty changegroup" which is not correct
  because we can send a changegroup without changelog with just manifest and
  filelogs and it will still say the same.
  
  Let's fix this to say that we are applying empty changelog from changegroup. In
  future patches I am will be adding functionality to send a changegroup from the
  server without an empty changelog.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4636

AFFECTED FILES
  mercurial/changegroup.py

CHANGE DETAILS

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -313,7 +313,7 @@
             efiles = len(efiles)
 
             if not cgnodes:
-                repo.ui.develwarn('applied empty changegroup',
+                repo.ui.develwarn('applied empty changelog from changegroup',
                                   config='warn-empty-changegroup')
             clend = len(cl)
             changesets = clend - clstart



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list