D4638: changegroup: add functionality to skip adding changelog data to changegroup

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Sep 18 13:53:32 EDT 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I think the code as written makes sense: I'd rather have 1 loop over `deltas` than 2.
  
  Regarding the other potential improvement, the reality of changegroups is that both they and bundle2 are container formats. In the context of bundle2, I think it makes more sense to send "delta groups" as individual bundle2 parts and to do away with changegroups completely. My guess is we haven't done this because the changegroup code has always existed, is non-trivial, and "just works." In other words, there hasn't been a pressing need to split up the changegroup code, so nobody has done it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4638

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list