D4666: fastannotate: process files as they arrive

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Sep 20 11:28:46 EDT 2018


indygreg added a comment.


  A futures-aware iterator is logically the correct thing to do. I just can't recall if that works with `commandexecutor` to the buffering nature of outgoing requests. It may require an explicit `e.close()` or `e.sendcommands()` to trigger sending the commands over the wire, or else things may deadlock (since I don't think a futures-aware iterator actually calls `result()`, which would trigger sending buffered commands).
  
  Not that it matters: we don't yet support out-of-order responses. We never will in wire protocol version 1. Version 2 should support it someday. At that time, we can audit wire protocol usage and switch to a futures-aware iterator, as appropriate.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4666

To: martinvonz, #hg-reviewers, indygreg
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list