D4684: changegroup: remove outdated comment

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Sep 20 19:39:26 UTC 2018


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4684

AFFECTED FILES
  mercurial/changegroup.py

CHANGE DETAILS

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -1120,9 +1120,6 @@
             commonctxs = [self._repo[c] for c in commonrevs]
             clrev = self._repo.changelog.rev
 
-            # Defining this function has a side-effect of overriding the
-            # function of the same name that was passed in as an argument.
-            # TODO have caller pass in appropriate function.
             def linknodes(flog, fname):
                 for c in commonctxs:
                     try:



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list