D4649: narrow: remove narrowrevlog

[indygreg (Gregory Szorc)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa063786c89fb: narrow: remove narrowrevlog (authored by indygreg, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D4649?vs=11183&id=11275

REVISION DETAIL
  https://phab.mercurial-scm.org/D4649

AFFECTED FILES
  hgext/narrow/TODO.rst
  hgext/narrow/__init__.py
  hgext/narrow/narrowrevlog.py

CHANGE DETAILS

diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py
deleted file mode 100644
--- a/hgext/narrow/narrowrevlog.py
+++ /dev/null
@@ -1,19 +0,0 @@
-# narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes
-#
-# Copyright 2017 Google, Inc.
-#
-# This software may be used and distributed according to the terms of the
-# GNU General Public License version 2 or any later version.
-
-from __future__ import absolute_import
-
-from mercurial import (
-   revlog,
-)
-
-revlog.addflagprocessor(revlog.REVIDX_ELLIPSIS, revlog.ellipsisprocessor)
-
-def setup():
-    # We just wanted to add the flag processor, which is done at module
-    # load time.
-    pass
diff --git a/hgext/narrow/__init__.py b/hgext/narrow/__init__.py
--- a/hgext/narrow/__init__.py
+++ b/hgext/narrow/__init__.py
@@ -28,7 +28,6 @@
     narrowcopies,
     narrowpatch,
     narrowrepo,
-    narrowrevlog,
     narrowtemplates,
     narrowwirepeer,
 )
@@ -58,7 +57,6 @@
 def uisetup(ui):
     """Wraps user-facing mercurial commands with narrow-aware versions."""
     localrepo.featuresetupfuncs.add(featuresetup)
-    narrowrevlog.setup()
     narrowbundle2.setup()
     narrowcommands.setup()
     narrowwirepeer.uisetup()
diff --git a/hgext/narrow/TODO.rst b/hgext/narrow/TODO.rst
--- a/hgext/narrow/TODO.rst
+++ b/hgext/narrow/TODO.rst
@@ -7,18 +7,11 @@
 came up the import to hgext, but nobody's got concrete improvement
 ideas as of then.
 
-Fold most (or preferably all) of narrowrevlog.py into core.
-
-Address commentary in narrowrevlog.excludedmanifestrevlog.add -
+Address commentary in manifest.excludedmanifestrevlog.add -
 specifically we should improve the collaboration with core so that
 add() never gets called on an excluded directory and we can improve
 the stand-in to raise a ProgrammingError.
 
-Figure out how to correctly produce narrowmanifestrevlog and
-narrowfilelog instances instead of monkeypatching regular revlogs at
-runtime to our subclass. Even better, merge the narrowing logic
-directly into core.
-
 Reason more completely about rename-filtering logic in
 narrowfilelog. There could be some surprises lurking there.
 



To: indygreg, durin42, #hg-reviewers
Cc: mercurial-devel