D4702: filelog: remove version attribute (API)

[indygreg (Gregory Szorc)]

indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This was only used by verify code. The check it was used for is now
  implemented as part of the verifyintegrity() implementation. The
  attribute is now unused, is revlog-specific, and isn't appropriate
  to be exposing on the file storage interface. So drop it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4702

AFFECTED FILES
  mercurial/filelog.py
  mercurial/repository.py
  tests/simplestorerepo.py

CHANGE DETAILS

diff --git a/tests/simplestorerepo.py b/tests/simplestorerepo.py
--- a/tests/simplestorerepo.py
+++ b/tests/simplestorerepo.py
@@ -109,8 +109,6 @@
         # This is used by changegroup code :/
         self._generaldelta = True
 
-        self.version = 1
-
     def _refreshindex(self):
         self._indexbynode.clear()
         self._indexbyrev.clear()
diff --git a/mercurial/repository.py b/mercurial/repository.py
--- a/mercurial/repository.py
+++ b/mercurial/repository.py
@@ -737,12 +737,6 @@
 class ifilestorage(ifileindex, ifiledata, ifilemutation):
     """Complete storage interface for a single tracked file."""
 
-    version = interfaceutil.Attribute(
-        """Version number of storage.
-
-        TODO this feels revlog centric and could likely be removed.
-        """)
-
     _generaldelta = interfaceutil.Attribute(
         """Whether deltas can be against any parent revision.
 
diff --git a/mercurial/filelog.py b/mercurial/filelog.py
--- a/mercurial/filelog.py
+++ b/mercurial/filelog.py
@@ -27,8 +27,6 @@
         self.filename = path
         # Used by repo upgrade.
         self.index = self._revlog.index
-        # Used by verify.
-        self.version = self._revlog.version
         # Used by changegroup generation.
         self._generaldelta = self._revlog._generaldelta
 



To: indygreg, #hg-reviewers
Cc: mercurial-devel