D4727: filelog: drop _generaldelta attribute (API)

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Sep 24 17:15:55 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  With changegroup moving to emitrevisions(), this revlog-specific
  attribute is no longer used and can be deleted. Good riddance.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4727

AFFECTED FILES
  mercurial/filelog.py
  mercurial/repository.py
  tests/simplestorerepo.py

CHANGE DETAILS

diff --git a/tests/simplestorerepo.py b/tests/simplestorerepo.py
--- a/tests/simplestorerepo.py
+++ b/tests/simplestorerepo.py
@@ -106,9 +106,6 @@
         self._index = []
         self._refreshindex()
 
-        # This is used by changegroup code :/
-        self._generaldelta = True
-
     def _refreshindex(self):
         self._indexbynode.clear()
         self._indexbyrev.clear()
diff --git a/mercurial/repository.py b/mercurial/repository.py
--- a/mercurial/repository.py
+++ b/mercurial/repository.py
@@ -741,13 +741,6 @@
 class ifilestorage(ifileindex, ifiledata, ifilemutation):
     """Complete storage interface for a single tracked file."""
 
-    _generaldelta = interfaceutil.Attribute(
-        """Whether deltas can be against any parent revision.
-
-        TODO this is used by changegroup code and it could probably be
-        folded into another API.
-        """)
-
     def files():
         """Obtain paths that are backing storage for this file.
 
diff --git a/mercurial/filelog.py b/mercurial/filelog.py
--- a/mercurial/filelog.py
+++ b/mercurial/filelog.py
@@ -25,8 +25,6 @@
         # Full name of the user visible file, relative to the repository root.
         # Used by LFS.
         self._revlog.filename = path
-        # Used by changegroup generation.
-        self._generaldelta = self._revlog._generaldelta
 
     def __len__(self):
         return len(self._revlog)



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list