D4752: filelog: return correct size when content begins with metadata prefix
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sat Sep 29 00:46:08 EDT 2018
yuja added a comment.
> The new call to read() should be fast because the revision
> fulltext should be cached as part of calling renamed(). So the
> overhead here should be minimal.
That isn't true unfortunately. `renamed()` reads the text only if p1 is null,
so `size()` was cheap in most cases. This patch makes `size()` as slow as
`len(read())`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4752
To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list