D6163: copies: extract function for deciding whether to use changeset-centric algos

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Apr 2 12:49:37 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> martinvonz wrote in copies.py:163
> I initially didn't have `use` and found it less clear. I also think "use changeset-centric" sounds weird. Maybe just `changesetcentric` as you said then, but that also seems unclear. It feels like we're working around https://phab.mercurial-scm.org/D2010. I can accept that we don't want to queue that, but I don't really like any of the shorter names either. Maybe the current name is fine given the docstring?

Or maybe there's another name that would work? Maybe `usecontextbasedalgo`? Or `shouldgetcopiesfromcontext`? Other suggestions?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6163

To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list