D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Apr 2 15:25:35 EDT 2019


indygreg added a comment.


  In https://phab.mercurial-scm.org/D6164#90074, @durin42 wrote:
  
  > In https://phab.mercurial-scm.org/D6164#90073, @indygreg wrote:
  >
  > > I would prefer you fix them :)
  >
  >
  > Okay, then what should we call it? `--extra-packages-script` since that's what it's for?
  
  
  Sounds good!
  
  And maybe change it to emit a newline delimited list of packages? I don't see a benefit to using `\0` since we don't need binary safety. IMO `\0` just makes it harder to implement said scripts.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6164

To: durin42, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list