D6188: test/test-revset2.t: Unset environment variable P
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Wed Apr 3 07:47:10 EDT 2019
pulkit added a comment.
Hi, the patch looks good. However, this lacks User info, Date and other metadata. Can you try using `hg phabsend` (https://www.mercurial-scm.org/wiki/Phabricator) or `hg email` the patch? (https://www.mercurial-scm.org/wiki/ContributingChanges#Sending_patches)
Also, append the commit description with (issueNNN) as suggested by https://www.mercurial-scm.org/wiki/ContributingChanges#Patch_descriptions.
To: jerry.montfort, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel