[PATCH] interactive: do not prompt about files given in command line

Pulkit Goyal 7895pulkit at gmail.com
Fri Apr 5 07:46:03 EDT 2019


On Fri, Apr 5, 2019 at 12:47 PM Denis Laxalde <denis at laxalde.org> wrote:

> # HG changeset patch
> # User Denis Laxalde <denis.laxalde at logilab.fr>
> # Date 1554370518 -7200
> #      Thu Apr 04 11:35:18 2019 +0200
> # Node ID 74a00c7446609592ccb6a3dc5ac98769ac36bfe8
> # Parent  4ee906aa7b60fb6b113e4dc187fbb5a8f42e557c
> interactive: do not prompt about files given in command line
>
> For commit and revert commands with --interactive and explicit files
> given in the command line, we now skip the invite to "examine changes to
> <file> ? [Ynesfdaq?]". The reason for this is that, if <file> is
> specified by the user, asking for confirmation is redundant.
>
> In patch.filterpatch(), we now use an optional "match" argument to
> conditionally call the prompt() function when entering a new "header"
> item. We use .exact() method to compare with files from the "header" in
> order to only consider (rel)path patterns.
>
> Add tests with glob patterns for commit and revert, to make sure we
> still ask to examine files in these cases.
>

Queued, many many thanks! I recently had an user complaining about this on
twitter.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190405/69ec4f6c/attachment.html>


More information about the Mercurial-devel mailing list