[PATCH] chistedit: properly show verbose diffs

[Yuya Nishihara]

On Mon, 08 Apr 2019 10:36:53 -0400, Jordi Gutiérrez Hermoso wrote:
> On Sat, 2019-04-06 at 09:46 +0900, Yuya Nishihara wrote:
> > On Thu, 04 Apr 2019 10:47:49 -0400, Jordi Gutiérrez Hermoso wrote:
> > > diff --git a/hgext/histedit.py b/hgext/histedit.py
> > > --- a/hgext/histedit.py
> > > +++ b/hgext/histedit.py
> > > @@ -1230,8 +1230,9 @@ def addln(win, y, x, line, color=None):
> > >  def patchcontents(state):
> > >      repo = state['repo']
> > >      rule = state['rules'][state['pos']]
> > > +    repo.ui.verbose = True
> > 
> > Perhaps, this has to be ui.configoverride() so the original value can be
> > restored.
> 
> I think we might just even set this "globally" for curses histedit.
> I'm not sure where else the ui.verbose value matters here except for
> displaying diffs.

I don't know whether or not we want ui.verbose globally. I'm just saying
it looks incorrect to set a temporary value to semi-global object.