[PATCH 8 of 8] match: let regex match function return a boolean

Martin von Zweigbergk martinvonz at google.com
Thu Apr 11 12:31:43 EDT 2019


Denis, I think this needs to be bool(x) instead of "x is not None". With
re2, we use compile(exp).test_match, which returns a boolean already, so I
think it will always be true with the current code.

On Mon, Apr 8, 2019 at 11:21 AM Augie Fackler <raf at durin42.com> wrote:

> On Mon, Apr 08, 2019 at 10:23:52AM +0200, Denis Laxalde wrote:
> > # HG changeset patch
> > # User Denis Laxalde <denis at laxalde.org>
> > # Date 1554648827 -7200
> > #      Sun Apr 07 16:53:47 2019 +0200
> > # Node ID de054cf2bda331787804762f411d1656333c43c4
> > # Parent  5adda8921403ce9aa216a823e69ab668ac674d8f
> > match: let regex match function return a boolean
>
> queued, thanks
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190411/6bcd0031/attachment.html>


More information about the Mercurial-devel mailing list