D6229: rust-dagops: range of revisions

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Sun Apr 14 15:45:46 EDT 2019


kevincox accepted this revision.
kevincox added inline comments.

INLINE COMMENTS

> dagops.rs:140
> +    let l = heads_ancestors.len();
> +    for i in 1..=l {
> +        let rev = heads_ancestors[l - i];

Can you use:

  for rev in heads_ancestors.into_iter().rev() {
     // ...
  }

> dagops.rs:215
> +        range(&graph, roots.iter().cloned(), heads.iter().cloned())
> +            .map(|bs| bs.iter().cloned().collect())
> +    }

Can you use `.into_iter()` instead of `.iter().cloned()`?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6229

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list