D6230: rust-dagops: roots

[kevincox (Kevin Cox)]

kevincox accepted this revision.
kevincox added inline comments.

INLINE COMMENTS

> dagops.rs:96
> +            .iter()
> +            .all(|p| *p == NULL_REVISION || !revs.contains(p))
> +        {

I think it is more clear to write `.iter().filter(|p| *p != NULL_REVISION).all(|p| !revs.contains(p))`. This separates the NULLs from the revs you care about and makes that condition easier to parse.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6230

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel