D6231: rust-discovery: starting core implementation

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Mon Apr 15 06:09:25 EDT 2019


gracinet added a comment.


  @kevincox Thanks for the reviews !
  
  > It would probably be better to have 3 classes and when you apply new information each class transitions into the next one. This allows the type system to ensure that you are using the class correctly.
  
  That's an interesting idea. I expect it to solve my gripes with `ensure_undecided()` neatly. I'm not sure how it'd fare on the Python side, and probably wouldn't do it in the bindings to maintain compatibility, but I'll play with it a bit.
  Maybe this could be a good topic for a follow-up ?
  Note: I still have the various sampling methods to submit today or tomorrow, but I think they would play well with that idea.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6231

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list