D6232: rust-discovery: cpython bindings for the core logic

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Mon Apr 15 12:06:16 EDT 2019


gracinet added inline comments.

INLINE COMMENTS

> test-rust-discovery.py:39
> +    b'\x00\x00\x00\x00\x00\x00\x00\x00\x00'
> +    )
> +

This is also exactly the same binary data I'm using in `test-rust-ancestors.py`. I'd prefer to mutualize them, but I'm not sure what the preferred pattern would be:

- binary file sitting next to the test module:

  with open(os.path.join(os.path.dirname(__file__), 'index_data.bin', 'rb')) as indexf):
           ...



- helper module next to the test module:

  from .index_data import non_inlined



- or even

  ``` from .index_data import parseindex ```

what would be the more inline with common practices within the Mercurial project ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6232

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list