D6231: rust-discovery: starting core implementation

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Mon Apr 15 12:59:36 EDT 2019


kevincox added inline comments.

INLINE COMMENTS

> gracinet wrote in discovery.rs:93
> I'm not sure. It wouldn't be a straight error to call this early, as long as the caller knows what this means, but I don't have any use-case before the discovery is complete.
> 
> On the other hand, I could go as far as consume the discovery object and use `self.common.into_bases_heads()`, but maybe that could make things more complicated for the Python bindings.

If it is allowed can you document what happens what happens if you call it before then?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6231

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list