D6182: bundle2: handle compression in _forwardchunks

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Apr 16 13:18:46 EDT 2019


durin42 added a comment.


  Ugh I'm sorry - I evidently reviewed this and never pushed submit. :(

INLINE COMMENTS

> bundle2.py:846
> +                if k.lower() != 'compression':
> +                    oparams.append(p)
> +            outparams = ' '.join(outparams)

so...what's going on with oparams here? should it be outparams?

(is there more to this series that would get this code covered by tests?)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6182

To: joerg.sonnenberger, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list