D6182: bundle2: handle compression in _forwardchunks

joerg.sonnenberger (Joerg Sonnenberger) phabricator at mercurial-scm.org
Tue Apr 16 16:23:21 EDT 2019


joerg.sonnenberger added inline comments.

INLINE COMMENTS

> durin42 wrote in bundle2.py:846
> so...what's going on with oparams here? should it be outparams?
> 
> (is there more to this series that would get this code covered by tests?)

Yes, left-over from earlier rename round. I think the code should handle multiple parameters, since I have no idea when we might run into them. At the same time, I have no idea right now how to test that case.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6182

To: joerg.sonnenberger, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list