D6255: copies: calculate mergecopies() based on pathcopies()
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Apr 16 17:08:28 EDT 2019
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6255#91019, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D6255#91015, @marmoute wrote:
> > I did a first path through it, the new code seems reasonable and easier
> > to read than the previous one. Some comments and questions below.
> The rest somehow didn't make it here, so I'll copy from the email (i.e. the below is from Pierre-Yves, not from me):
> > Some timings for calculating mergecopies between two revisions (all
> > using the common ancestor as base):
> Which revisions did you pick?
The revisions are those before the colon, so e.g. from hg version 4.0 to 4.8. Oops, the first line there should say "4.8 4.9", not "4.8 4.8". I've fixed that now.
>> In the hg repo:
>> 4.8 4.8: 0.21s -> 0.21s
>> 4.0 4.8: 0.35s -> 0.63s
>> In and old copy of the mozilla-unified repo:
>> FIREFOX_BETA_60_BASE^ FIREFOX_BETA_60_BASE: 0.51s -> 0.60s
>> FIREFOX_NIGHTLY_59_END FIREFOX_BETA_60_BASE: 2.1s -> 2.3s
>> FIREFOX_BETA_59_END FIREFOX_BETA_60_BASE: 3.1s -> 3.3s
>> FIREFOX_AURORA_50_BASE FIREFOX_BETA_60_BASE: 30s -> 35s
To: martinvonz, #hg-reviewers
Cc: marmoute, mjpieters, mercurial-devel
More information about the Mercurial-devel