D6238: branchcache: don't verify while creating a copy

Yuya Nishihara yuya at tcha.org
Tue Apr 16 19:05:00 EDT 2019


>      def copy(self):
>          """return an deep copy of the branchcache object"""
> -        self._verifyall()
>          return type(self)(
>              self._entries, self.tipnode, self.tiprev, self.filteredhash,
>              self._closednodes)

Looks good, but it's probably better to copy the verification state to
new instance, or simply make branchcache() start with "verified" state.
IIUC, only branches loaded from file have to be validated.


More information about the Mercurial-devel mailing list