D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

[indygreg (Gregory Szorc)]

indygreg added a comment.


  This patch is backwards incompatible over the wire protocol.
  
  The problem is a new client will blindly send part data to an old server expecting part parameters. The old server won't read the part data and it would be as if the includes and excludes were not sent.
  
  We need some kind of capability negotiation that allows the client to opt in to the newer behavior if the server advertises support for it.
  
  Also, my personal preference is to create new bundle2 parts rather than change behavior of existing bundle2 parts. Doing things this way ensures that behavior for a named bundle2 part is constant over time. This keeps implementations simpler, as individual part handling can do one thing and one thing only.
  
  Finally, the internals help docs should be updated to reflect changes to bundle2 part behavior.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6218

To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: indygreg, idlsoft, mercurial-devel