D6231: rust-discovery: starting core implementation
gracinet (Georges Racinet)
phabricator at mercurial-scm.org
Wed Apr 17 08:32:51 EDT 2019
gracinet marked an inline comment as done.
gracinet added a comment.
I believe to have addressed your immediate concerns.
I played with splitting in different `struct`s for the various stages of the process. It is indeed cleaner and clearer Rust code.
However mutating in place of `Enum`s exposed to Python is a bit of a headache, because of the wrapping in `RefCell<Box<T>>`, and I don't have a solution for that, so I'm gonna think about that in a follow-up.
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel
More information about the Mercurial-devel