D6231: rust-discovery: starting core implementation
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Wed Apr 17 08:58:53 EDT 2019
kevincox added a comment.
In https://phab.mercurial-scm.org/D6231#91102, @gracinet wrote:
> I believe to have addressed your immediate concerns.
> I played with splitting in different `struct`s for the various stages of the process. It is indeed cleaner and clearer Rust code.
> However mutating in place of `Enum`s exposed to Python is a bit of a headache, because of the wrapping in `RefCell<Box<T>>`, and I don't have a solution for that, so I'm gonna think about that in a follow-up.
Thanks, it looks good for now :)
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel
More information about the Mercurial-devel