[PATCH] repoview: introduce a `experimental.extra-filter-revs` config

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Apr 17 10:13:39 EDT 2019



On 4/17/19 2:08 PM, Gregory Szorc wrote:
> 
> 
>> On Apr 17, 2019, at 13:34, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>
>>
>>
>>> On 4/17/19 1:22 PM, Gregory Szorc wrote:
>>>     diff --git a/tests/test-server-view.t b/tests/test-server-view.t
>>>     --- a/tests/test-server-view.t
>>>     +++ b/tests/test-server-view.t
>>>     @@ -34,5 +34,21 @@
>>>         date:        Thu Jan 01 00:00:00 1970 +0000
>>>         summary:     r0
>>>     +
>>>     +Check same result using `experimental.extra-filter-revs`
>>>     +
>>>     +  $ hg -R test --config experimental.extra-filter-revs='not
>>>     public()' serve -p $HGPORT1 -d --pid-file=hg2.pid -E errors.log
>>>     +  $ cat hg2.pid >> $DAEMON_PIDS
>>>     +  $ hg -R test2 incoming http://foo:xyzzy@localhost:$HGPORT1/
>>>     +  comparing with http://foo:***@localhost:$HGPORT1/
>>>     +  changeset:   0:1ea73414a91b
>>>     +  tag:         tip
>>>     +  user:        debugbuilddag
>>>     +  date:        Thu Jan 01 00:00:00 1970 +0000
>>>     +  summary:     r0
>>>     +
> 
> Could we also please get a test that the on-disk cache file(s) are crested as expected?
> 
> Regarding those on-disk cache files, are there any cache invalidation issues since revsets are dynamic? (I think we’re OK but I want to make sure we have thought things through.)

The cache validated themselves based on the skipped revision, so they 
will not use an invalid caches whichever it comes from (disk, subset, etc…).

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list