D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Apr 17 12:44:12 EDT 2019


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D6218#91121, @idlsoft wrote:
  
  > Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part.
  >  This would make things cleaner probably, but I'll deal with whatever solution you guys settle on.
  
  
  I think bundle2 parts can be marked mandatory (by using uppercase in their name?). It seems to me like the ACL part should be mandatory. Is that correct, Sandu? So that's a good point and thanks for mentioning that. Pulkit, I think it's enough to change the name to be something like `narrow:Spec` or `Narrow:spec` (I'm thinking the former since some narrow parts are mandatory and some are not and then they all still start with `narrow:`).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6218

To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: indygreg, idlsoft, mercurial-devel


More information about the Mercurial-devel mailing list