D5299: phabricator: fallback reading arcanist config files

Kwan (Ian Moody) phabricator at mercurial-scm.org
Fri Apr 19 04:08:21 EDT 2019


Kwan added inline comments.

INLINE COMMENTS

> philpep wrote in phabricator.py:201
> HINT: This doesn't work for current mercurial config because "arc install-certificates" add a trailing "/" to conduit_uri and our .arcconfig doesn't have this trailing slash.
> Any idea how to handle this properly ?

I think you could do

  url = util.url(conduit_uri)
  url.path = None
  url = b'%s' % url

Also I think you need to check for `phabricator.uri` first, then fall back to `conduit_uri`, see change to phabricator's .arcconfig <https://github.com/phacility/phabricator/commit/f0e6dc122109bcc2c3cade0af04b3f06af2fe50b> and mozilla-central's current one <https://hg.mozilla.org/mozilla-central/file/f7a15eb24f3d/.arcconfig> (and perhaps rename conduit_uri variable appropriately)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5299

To: philpep, #hg-reviewers
Cc: Kwan, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list