D6283: automation: only iterate over our AMIs
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Apr 19 12:20:55 UTC 2019
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We can't delete AMIs that we don't own. Iterating over other
AMIs won't work and slows down execution.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6283
AFFECTED FILES
contrib/automation/hgautomation/aws.py
CHANGE DETAILS
diff --git a/contrib/automation/hgautomation/aws.py b/contrib/automation/hgautomation/aws.py
--- a/contrib/automation/hgautomation/aws.py
+++ b/contrib/automation/hgautomation/aws.py
@@ -490,7 +490,7 @@
terminate_ec2_instances(ec2resource, prefix=prefix)
- for image in ec2resource.images.all():
+ for image in ec2resource.images.filter(Owners=['self']):
if image.name.startswith(prefix):
remove_ami(ec2resource, image)
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list