D6267: incoming: detect if server send partial replies

[indygreg (Gregory Szorc)]

indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> bundlerepo.py:642
> +            ui.warn(_("warning: the server did not send all changes; "
> +                      "the follow list is incomplete\n"))
> +            rheads = [x for x in rheads if hasnode(x)]

Something I didn't notice before is that this function doesn't do any UI presentation. So it feels like a bug to print a message in this function assuming that fetched changesets will be displayed.

I suppose that means we'll need to include the "was partial reply" state in the return value and format it to a warning elsewhere.

Sorry for not catching this on first review. I intend to queue this patch for stable so it gets in the 5.0 release, as I think the improved UI is good to have.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6267

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel