D6301: phabricator: fallback to reading metadata from diff for phabread
Kwan (Ian Moody)
phabricator at mercurial-scm.org
Mon Apr 22 14:08:50 EDT 2019
Kwan added inline comments.
INLINE COMMENTS
> phabricator.py:926
> + meta = {}
> + if b'date' not in meta and b'dateCreated' in diff:
> + meta[b'date'] = b'%s 0' % diff[b'dateCreated']
I didn't use `get` here because "dateCreated" is set by conduit, not the submitted data, so should always be present and valid (but will make it `get` if requested).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6301
To: Kwan, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list